[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2024090311-foam-pouncing-fcdd@gregkh>
Date: Tue, 3 Sep 2024 12:19:26 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: srinivas.kandagatla@...aro.org
Cc: linux-kernel@...r.kernel.org, Sukrut Bellary <sukrut.bellary@...ux.com>,
Shuah Khan <skhan@...uxfoundation.org>,
Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH 1/1] misc: fastrpc: Fix double free of 'buf' in error path
On Mon, Sep 02, 2024 at 03:14:09PM +0100, srinivas.kandagatla@...aro.org wrote:
> From: Sukrut Bellary <sukrut.bellary@...ux.com>
>
> smatch warning:
> drivers/misc/fastrpc.c:1926 fastrpc_req_mmap() error: double free of 'buf'
>
> In fastrpc_req_mmap() error path, the fastrpc buffer is freed in
> fastrpc_req_munmap_impl() if unmap is successful.
>
> But in the end, there is an unconditional call to fastrpc_buf_free().
> So the above case triggers the double free of fastrpc buf.
>
> Fixes: 72fa6f7820c4 ("misc: fastrpc: Rework fastrpc_req_munmap")
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Signed-off-by: Sukrut Bellary <sukrut.bellary@...ux.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
> drivers/misc/fastrpc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Any reason you forgot a cc: stable@ on this?
I'll go add it by hand...
Powered by blists - more mailing lists