linux-kernel - Re: [PATCH 1/1] misc: fastrpc: Fix double free of 'buf' in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ffb8938-bd3b-45b0-a7fe-733ea9646ed8@linaro.org>
Date: Tue, 3 Sep 2024 11:46:31 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, Sukrut Bellary <sukrut.bellary@...ux.com>,
 Shuah Khan <skhan@...uxfoundation.org>,
 Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH 1/1] misc: fastrpc: Fix double free of 'buf' in error path



On 03/09/2024 11:19, Greg KH wrote:
> On Mon, Sep 02, 2024 at 03:14:09PM +0100, srinivas.kandagatla@...aro.org wrote:
>> From: Sukrut Bellary <sukrut.bellary@...ux.com>
>>
>> smatch warning:
>> drivers/misc/fastrpc.c:1926 fastrpc_req_mmap() error: double free of 'buf'
>>
>> In fastrpc_req_mmap() error path, the fastrpc buffer is freed in
>> fastrpc_req_munmap_impl() if unmap is successful.
>>
>> But in the end, there is an unconditional call to fastrpc_buf_free().
>> So the above case triggers the double free of fastrpc buf.
>>
>> Fixes: 72fa6f7820c4 ("misc: fastrpc: Rework fastrpc_req_munmap")
>> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
>> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
>> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> Signed-off-by: Sukrut Bellary <sukrut.bellary@...ux.com>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> ---
>>   drivers/misc/fastrpc.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Any reason you forgot a cc: stable@ on this?
> 
I think it was forgotten.
> I'll go add it by hand...
Thanks for doing this.

--srini
>