[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6fed4714-5239-473b-b4a0-886d83c459c3@quicinc.com>
Date: Wed, 4 Sep 2024 05:54:13 -0700
From: Nikunj Kela <quic_nkela@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <andersson@...nel.org>, <konradybcio@...nel.org>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <rafael@...nel.org>,
<viresh.kumar@...aro.org>, <herbert@...dor.apana.org.au>,
<davem@...emloft.net>, <sudeep.holla@....com>, <andi.shyti@...nel.org>,
<tglx@...utronix.de>, <will@...nel.org>, <robin.murphy@....com>,
<joro@...tes.org>, <jassisinghbrar@...il.com>, <lee@...nel.org>,
<linus.walleij@...aro.org>, <amitk@...nel.org>,
<thara.gopinath@...il.com>, <broonie@...nel.org>,
<cristian.marussi@....com>, <rui.zhang@...el.com>,
<lukasz.luba@....com>, <wim@...ux-watchdog.org>, <linux@...ck-us.net>,
<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
<linux-crypto@...r.kernel.org>, <arm-scmi@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <linux-i2c@...r.kernel.org>,
<iommu@...ts.linux.dev>, <linux-gpio@...r.kernel.org>,
<linux-serial@...r.kernel.org>, <linux-spi@...r.kernel.org>,
<linux-watchdog@...r.kernel.org>, <kernel@...cinc.com>,
<quic_psodagud@...cinc.com>, Praveen Talari <quic_ptalari@...cinc.com>
Subject: Re: [PATCH v2 17/21] dt-bindings: serial: document support for
SA8255p
On 9/3/2024 11:36 PM, Krzysztof Kozlowski wrote:
> On Tue, Sep 03, 2024 at 03:02:36PM -0700, Nikunj Kela wrote:
>> Add compatibles representing UART support on SA8255p.
>>
>> Clocks and interconnects are being configured in the firmware VM
>> on SA8255p platform, therefore making them optional.
>>
>> CC: Praveen Talari <quic_ptalari@...cinc.com>
>> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
>> ---
>> .../serial/qcom,serial-geni-qcom.yaml | 53 ++++++++++++++++---
>> 1 file changed, 47 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>> index dd33794b3534..b63c984684f3 100644
>> --- a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>> +++ b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>> @@ -10,14 +10,13 @@ maintainers:
>> - Andy Gross <agross@...nel.org>
>> - Bjorn Andersson <bjorn.andersson@...aro.org>
>>
>> -allOf:
>> - - $ref: /schemas/serial/serial.yaml#
>> -
>> properties:
>> compatible:
>> enum:
>> - qcom,geni-uart
>> - qcom,geni-debug-uart
>> + - qcom,sa8255p-geni-uart
>> + - qcom,sa8255p-geni-debug-uart
> Why devices are not compatible? What changed in programming model?
The cover-letter explains what is changed for devices in this platform.
I will add the description in this patch too.
>
>>
>> clocks:
>> maxItems: 1
>> @@ -51,18 +50,49 @@ properties:
>> - const: sleep
>>
>> power-domains:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>> +
>> + power-domain-names:
> This does not match power-domains anymore.
Single power domain doesn't need to use power-domain-names binding as it
is not needed however for multiple(in this case 2), you need to provide
names. I will add this property to if block and only keep maxItems here.
>
>> + items:
>> + - const: power
>> + - const: perf
>>
>> reg:
>> maxItems: 1
>>
>> required:
>> - compatible
>> - - clocks
>> - - clock-names
>> - interrupts
>> - reg
>>
>> +allOf:
>> + - $ref: /schemas/serial/serial.yaml#
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sa8255p-geni-uart
>> + - qcom,sa8255p-geni-debug-uart
>> + then:
>> + required:
>> + - power-domains
>> + - power-domain-names
>> +
>> + properties:
>> + power-domains:
>> + minItems: 2
>> +
>> + else:
>> + required:
>> + - clocks
>> + - clock-names
>> +
>> + properties:
>> + power-domains:
>> + maxItems: 1
>> +
>> unevaluatedProperties: false
>>
>> examples:
>> @@ -83,4 +113,15 @@ examples:
>> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>;
>> interconnect-names = "qup-core", "qup-config";
>> };
>> +
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> + serial@...000 {
>> + compatible = "qcom,sa8255p-geni-uart";
>> + reg = <0x990000 0x4000>;
>> + interrupts = <GIC_SPI 531 IRQ_TYPE_LEVEL_HIGH>;
>> + power-domains = <&scmi11_pd 4>, <&scmi11_dvfs 4>;
>> + power-domain-names = "power", "perf";
>> + };
>> ...
>> --
>> 2.34.1
>>
Powered by blists - more mailing lists