linux-kernel - Re: [PATCH v2 17/21] dt-bindings: serial: document support for SA8255p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <634ab05e-3b8c-4cc1-bf23-0c68c1d28484@quicinc.com>
Date: Wed, 4 Sep 2024 05:56:23 -0700
From: Nikunj Kela <quic_nkela@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <andersson@...nel.org>, <konradybcio@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <rafael@...nel.org>,
        <viresh.kumar@...aro.org>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>, <sudeep.holla@....com>, <andi.shyti@...nel.org>,
        <tglx@...utronix.de>, <will@...nel.org>, <robin.murphy@....com>,
        <joro@...tes.org>, <jassisinghbrar@...il.com>, <lee@...nel.org>,
        <linus.walleij@...aro.org>, <amitk@...nel.org>,
        <thara.gopinath@...il.com>, <broonie@...nel.org>,
        <cristian.marussi@....com>, <rui.zhang@...el.com>,
        <lukasz.luba@....com>, <wim@...ux-watchdog.org>, <linux@...ck-us.net>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <arm-scmi@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-i2c@...r.kernel.org>,
        <iommu@...ts.linux.dev>, <linux-gpio@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-spi@...r.kernel.org>,
        <linux-watchdog@...r.kernel.org>, <kernel@...cinc.com>,
        <quic_psodagud@...cinc.com>, Praveen Talari <quic_ptalari@...cinc.com>
Subject: Re: [PATCH v2 17/21] dt-bindings: serial: document support for
 SA8255p


On 9/4/2024 12:47 AM, Krzysztof Kozlowski wrote:
> On 04/09/2024 00:02, Nikunj Kela wrote:
>> Add compatibles representing UART support on SA8255p.
>>
>> Clocks and interconnects are being configured in the firmware VM
>> on SA8255p platform, therefore making them optional.
>>
>> CC: Praveen Talari <quic_ptalari@...cinc.com>
>> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
>> ---
>>  .../serial/qcom,serial-geni-qcom.yaml         | 53 ++++++++++++++++---
>>  1 file changed, 47 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>> index dd33794b3534..b63c984684f3 100644
>> --- a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>> +++ b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>> @@ -10,14 +10,13 @@ maintainers:
>>    - Andy Gross <agross@...nel.org>
>>    - Bjorn Andersson <bjorn.andersson@...aro.org>
>>  
>> -allOf:
>> -  - $ref: /schemas/serial/serial.yaml#
>> -
>>  properties:
>>    compatible:
>>      enum:
>>        - qcom,geni-uart
>>        - qcom,geni-debug-uart
>> +      - qcom,sa8255p-geni-uart
>> +      - qcom,sa8255p-geni-debug-uart
>
> Anyway, the entire patchset is organized wrong. Or you sent only subset.
>
> Where is the driver change? This cannot work. To remind bindings go with
> the driver (nothing new here).
>
> Best regards,
> Krzysztof

The driver changes will soon be posted. They are being reviewed
internally. For a quick look on what is coming next, you can refer to
CodeLinaro git repo[1]

[1]:
https://git.codelinaro.org/clo/linux-kernel/kernel-qcom/-/tree/nkela/sa8255p_v6_11_rc2?ref_type=heads