lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240904-pipe-correct_imprecise_wording-v1-1-2b07843472c2@efficios.com>
Date: Wed, 04 Sep 2024 10:13:29 -0400
From: Kienan Stewart <kstewart@...icios.com>
To: Alexander Viro <viro@...iv.linux.org.uk>, 
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-janitors@...r.kernel.org, Kienan Stewart <kstewart@...icios.com>
Subject: [PATCH] fs/pipe: Correct imprecise wording in comment

The comment inaccurately describes what pipefs is - that is, a file
system.

Signed-off-by: Kienan Stewart <kstewart@...icios.com>
---
Hi,

while reading through `pipe.c`, I noticed that the comment explaining
why pipefs should not be mounted in user space inaccurately describes
what pipefs is - that is, a file system.

While I understand the original language used in context, I believe
this change increases the legibility of the comment.

thanks,
kienan
---
 fs/pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/pipe.c b/fs/pipe.c
index 7dff2aa50a6d..9a6dfe39f012 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -1427,7 +1427,7 @@ static const struct super_operations pipefs_ops = {
 
 /*
  * pipefs should _never_ be mounted by userland - too much of security hassle,
- * no real gain from having the whole whorehouse mounted. So we don't need
+ * no real gain from having the whole file system mounted. So we don't need
  * any operations on the root directory. However, we need a non-trivial
  * d_name - pipe: will go nicely and kill the special-casing in procfs.
  */

---
base-commit: d5d547aa7b51467b15d9caa86b116f8c2507c72a
change-id: 20240829-pipe-correct_imprecise_wording-d20e370edbc0

Best regards,
-- 
Kienan Stewart <kstewart@...icios.com>


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ