linux-kernel - Re: [PATCH 2/2] interconnect: qcom: add QCS8300 interconnect provider driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <469176a3-24ea-4ed1-84ca-71704cf70e88@quicinc.com>
Date: Wed, 4 Sep 2024 09:51:43 +0530
From: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
CC: Konrad Dybcio <konradybcio@...nel.org>,
        Danila Tikhonov
	<danila@...xyga.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        "Vladimir
 Lypak" <vladimir.lypak@...il.com>,
        Adam Skladowski <a39.skl@...il.com>,
        "Sibi
 Sankar" <quic_sibis@...cinc.com>,
        Rohit Agarwal <quic_rohiagar@...cinc.com>,
        Rajendra Nayak <quic_rjendra@...cinc.com>,
        Andrew Halaney
	<ahalaney@...hat.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_mdtipton@...cinc.com>,
        <quic_okukatla@...cinc.com>
Subject: Re: [PATCH 2/2] interconnect: qcom: add QCS8300 interconnect provider
 driver


On 8/27/2024 8:58 PM, Krzysztof Kozlowski wrote:
> On 27/08/2024 17:16, Raviteja Laggyshetty wrote:
>> Add driver for the Qualcomm interconnect buses found in QCS8300
>> based platforms. The topology consists of several NoCs that are
>> controlled by a remote processor that collects the aggregated
>> bandwidth for each master-slave pairs.
>>
>> +
>> +static struct qcom_icc_node *nspa_noc_nodes[] = {
>> +	[MASTER_CDSP_NOC_CFG] = &qhm_nsp_noc_config,
>> +	[MASTER_CDSP_PROC] = &qxm_nsp,
>> +	[SLAVE_HCP_A] = &qns_hcp,
>> +	[SLAVE_CDSP_MEM_NOC] = &qns_nsp_gemnoc,
>> +	[SLAVE_SERVICE_NSP_NOC] = &service_nsp_noc,
>> +};
>> +
>> +static struct qcom_icc_desc qcs8300_nspa_noc = {
> Sorry, but no. Start from scratch from MAINLINE driver so you won't
> repeat all the issues we fixed last years. Everything was fixed but then
> you send one more driver with exact same issues. EXACT.
>
> This applies to all QCS8300 submissions... actually this applies to all
> contributions to Linux kernel. Don't send your downstream code.

Thanks for the review!

Sure, will adhere to the existing upstream code in the next patch revision.

I will constify all the array of pointers to structs as done in the existing upstream code.

I will refer the existing upstream code for any other missed fixes. Let me know, if there is any other miss.

> Best regards,
> Krzysztof

Thanks,

Raviteja.