linux-kernel - Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp: Add Microsoft Surface Pro 9 5G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtgSgDq2_y-7NpHm@hovoldconsulting.com>
Date: Wed, 4 Sep 2024 09:55:44 +0200
From: Johan Hovold <johan@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Jérôme de Bretagne <jerome.debretagne@...il.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Johan Hovold <johan+linaro@...nel.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp: Add Microsoft Surface
 Pro 9 5G

On Wed, Sep 04, 2024 at 09:54:26AM +0200, Johan Hovold wrote:
> On Wed, Sep 04, 2024 at 09:46:09AM +0200, Krzysztof Kozlowski wrote:
> > On 04/09/2024 00:42, Jérôme de Bretagne wrote:
> > > Add an initial devicetree for the Microsoft Surface Pro 9 5G, based
> > > on SC8280XP.
> 
> > Rest looks good, except ordering of nodes/overrides/phandles. They
> > should go alphabetically, AFAIR, so your &tlmm is placed in wrong spot.
> 
> For the other sc8280xp machines (and I believe at least some other
> SoCs), we placed the pinctrl section, which tends to be quite long, last
> on purpose with a separating header (e.g. so that it is easy to find):
> 
> 	/* PINCTRL */
> 
> 	&pmr735a_gpios {
> 	...
> 
> 	&tlmm {
> 
> 
> Looks like the header comment is missing here if you want to follow that
> style, though.

No, the header is already there, sorry.

Johan