[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cbfee403-0fc0-4ac7-bce7-5f7560ed2ea3@kernel.org>
Date: Wed, 4 Sep 2024 09:56:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Johan Hovold <johan@...nel.org>
Cc: Jérôme de Bretagne <jerome.debretagne@...il.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Johan Hovold <johan+linaro@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp: Add Microsoft Surface Pro
9 5G
On 04/09/2024 09:54, Johan Hovold wrote:
> On Wed, Sep 04, 2024 at 09:46:09AM +0200, Krzysztof Kozlowski wrote:
>> On 04/09/2024 00:42, Jérôme de Bretagne wrote:
>>> Add an initial devicetree for the Microsoft Surface Pro 9 5G, based
>>> on SC8280XP.
>
>> Rest looks good, except ordering of nodes/overrides/phandles. They
>> should go alphabetically, AFAIR, so your &tlmm is placed in wrong spot.
>
> For the other sc8280xp machines (and I believe at least some other
> SoCs), we placed the pinctrl section, which tends to be quite long, last
> on purpose with a separating header (e.g. so that it is easy to find):
>
> /* PINCTRL */
>
> &pmr735a_gpios {
> ...
>
> &tlmm {
>
>
> Looks like the header comment is missing here if you want to follow that
> style, though.
If that is the style here, no problem for me. With two node name fixes:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists