linux-kernel - Re: [PATCH] soc: fsl: cpm1: qmc: Fix dependency on fsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240904103313.21aed2de@bootlin.com>
Date: Wed, 4 Sep 2024 10:33:13 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>, Arnd Bergmann <arnd@...db.de>,
 linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Qiang Zhao <qiang.zhao@....com>
Subject: Re: [PATCH] soc: fsl: cpm1: qmc: Fix dependency on fsl_soc.h

Hi Christophe,

On Wed,  4 Sep 2024 09:51:09 +0200
Christophe Leroy <christophe.leroy@...roup.eu> wrote:

> QMC driver requires fsl_soc.h to use function get_immrbase().
> This header is provided by powerpc architecture and the functions
> it declares are defined only when FSL_SOC is selected.
> 
> Today the dependency is the following:
> 
> 	depends on CPM1 || QUICC_ENGINE || \
> 		   (FSL_SOC && (CPM || QUICC_ENGINE) && COMPILE_TEST)
> 
> This dependency tentatively ensure that FSL_SOC is there when doing a
> COMPILE_TEST.
> 
> CPM1 is only selected by PPC_8xx and cannot be selected manually.
> CPM1 selects FSL_SOC
> 
> QUICC_ENGINE on the other hand can be selected by ARM or ARM64 which
> doesn't select FSL_SOC. QUICC_ENGINE can also be selected with just
> COMPILE_TEST.
> 
> It is therefore possible to end up with CPM_QMC selected
> without FSL_SOC.
> 
> So fix it by making it depend on FSL_SOC at all time.
> 
> The rest of the above dependency is the same as the one for CPM_TSA on
> which CPM_QMC also depends, so it can go away, leaving only a simple
> dependency on FSL_SOC.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/lkml/20240904104859.020fe3a9@canb.auug.org.au/
> Fixes: 8655b76b7004 ("soc: fsl: cpm1: qmc: Handle QUICC Engine (QE) soft-qmc firmware")
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>

Thanks for this patch!

Acked-by: Herve Codina <herve.codina@...tlin.com>

Best regards,
Hervé