linux-kernel - Re: [PATCH net] net: dsa: felix: ignore pending status of TAS module when it's disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904101213.oqdf3brqlzzmgln5@skbuf>
Date: Wed, 4 Sep 2024 13:12:13 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Xiaoliang Yang <xiaoliang.yang_1@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, claudiu.manoil@....com,
	alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com,
	andrew@...n.ch, f.fainelli@...il.com, michael@...le.cc,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: felix: ignore pending status of TAS module
 when it's disabled

Hi Xiaoliang,

On Wed, Sep 04, 2024 at 06:27:22PM +0800, Xiaoliang Yang wrote:
> The TAS module could not be configured when it's running in pending
> status. We need disable the module and configure it again. However, the
> pending status is not cleared after the module disabled. So we don't
> need to check the pending status if TAS module is disabled.
> 
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@....com>
> ---

Does this fix a functional, user-visible problem? If so, which problem is that?
Could you describe it in the commit message? And maybe add a Fixes: tag
to the patch where the problem was first visible?