linux-kernel - RE: [PATCH net] net: dsa: felix: ignore pending status of TAS module when it's disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DB9PR04MB9259A724BCA28FA199B94E57F09E2@DB9PR04MB9259.eurprd04.prod.outlook.com>
Date: Fri, 6 Sep 2024 09:14:28 +0000
From: Xiaoliang Yang <xiaoliang.yang_1@....com>
To: Vladimir Oltean <vladimir.oltean@....com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, Claudiu Manoil
	<claudiu.manoil@....com>, "alexandre.belloni@...tlin.com"
	<alexandre.belloni@...tlin.com>, "UNGLinuxDriver@...rochip.com"
	<UNGLinuxDriver@...rochip.com>, "andrew@...n.ch" <andrew@...n.ch>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>, "michael@...le.cc"
	<michael@...le.cc>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net] net: dsa: felix: ignore pending status of TAS module
 when it's disabled

Hi Vladimir,

Yes, it's a user-visible problem. User can't reconfigured Qbv once the TAS is 
in pending status(configured the Qbv basetime as a future time). The driver 
always returns busy. Actually Qbv can be reconfigured after it's disabled. 
I update the commit to descript it and send in a new patch.

Thanks,
Xiaoliang

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@....com>
> Sent: Wednesday, September 4, 2024 6:12 PM
> To: Xiaoliang Yang <xiaoliang.yang_1@....com>
> Cc: netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org;
> pabeni@...hat.com; Claudiu Manoil <claudiu.manoil@....com>;
> alexandre.belloni@...tlin.com; UNGLinuxDriver@...rochip.com;
> andrew@...n.ch; f.fainelli@...il.com; michael@...le.cc;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net] net: dsa: felix: ignore pending status of TAS module
> when it's disabled
> 
> Hi Xiaoliang,
> 
> On Wed, Sep 04, 2024 at 06:27:22PM +0800, Xiaoliang Yang wrote:
> > The TAS module could not be configured when it's running in pending
> > status. We need disable the module and configure it again. However,
> > the pending status is not cleared after the module disabled. So we
> > don't need to check the pending status if TAS module is disabled.
> >
> > Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@....com>
> > ---
> 
> Does this fix a functional, user-visible problem? If so, which problem is that?
> Could you describe it in the commit message? And maybe add a Fixes: tag to
> the patch where the problem was first visible?