linux-kernel - Re: [PATCH v7 2/8] i2c: muxes: add support for tsd,mule-i2c multiplexer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b12ac5ac-306f-4f36-895a-e1472ff86271@cherry.de>
Date: Wed, 4 Sep 2024 12:23:56 +0200
From: Farouk Bouabid <farouk.bouabid@...rry.de>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Quentin Schulz
 <quentin.schulz@...rry.de>, Peter Rosin <peda@...ntia.se>,
 Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 Heiko Stuebner <heiko@...ech.de>, linux-i2c@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: [PATCH v7 2/8] i2c: muxes: add support for tsd,mule-i2c
 multiplexer

Hi Andi,

On 03.09.24 17:13, Andi Shyti wrote:
>> Theobroma Systems Mule is an MCU that emulates a set of I2C devices,
>> among which an amc6821 and devices that are reachable through an I2C-mux.
>> The devices on the mux can be selected by writing the appropriate device
>> number to an I2C config register (amc6821 reg 0xff).
>>
>> This driver is expected to be probed as a platform device with amc6821
>> as its parent i2c device.
>>
>> Add support for the mule-i2c-mux platform driver. The amc6821 driver
> Along the driver I expressed some concern about the prefixes.
>
> You should avoid prefixes such as mux_* or MUX_* because they
> don't belong to your driver. You should always use your driver's
> name:
>
>   1. mule_*
>   2. mule_mux_*
>   3. mule_i2c_mux_*
>
> You have used the 3rd, I'd rather prefer the 1st. Because when
> you are in i2c/muxex/ it's implied that you are an i2c mux
> device. But it's a matter of personal taste.
>

Are you here referring to the commit log, module name or function 
prefixes ? (because  later you suggested that we use "mule_i2c_mux_*" 
for functions)

"Mule" is a chip that requires multiple drivers that will be added later 
on, and I suppose we don't want conflict with other module names ?


Thanks,

Farouk