linux-kernel - Re: [PATCH v3 04/12] ext4: let __revise_pending() return newly inserted pendings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904102334.a2th4zv4szuae7by@quack3>
Date: Wed, 4 Sep 2024 12:23:34 +0200
From: Jan Kara <jack@...e.cz>
To: Zhang Yi <yi.zhang@...weicloud.com>
Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, tytso@....edu,
	adilger.kernel@...ger.ca, jack@...e.cz, ritesh.list@...il.com,
	yi.zhang@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com
Subject: Re: [PATCH v3 04/12] ext4: let __revise_pending() return newly
 inserted pendings

On Wed 04-09-24 12:15:15, Jan Kara wrote:
> On Tue 13-08-24 20:34:44, Zhang Yi wrote:
> > From: Zhang Yi <yi.zhang@...wei.com>
> > 
> > Let __insert_pending() return 1 after successfully inserting a new
> > pending cluster, and also let __revise_pending() to return the number of
> > of newly inserted pendings.
> > 
> > Signed-off-by: Zhang Yi <yi.zhang@...wei.com>
> 
> AFAICS nothing really uses this functionality in this version of the
> patchset so we can drop this patch?

Now I've realized patch 6 indeed uses the new return value in one place.
This patch looks good so feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR