linux-kernel - Re: [PATCH v2] kbuild: pahole-version: improve overall checking and error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATf7A1z38rQP5tHKb0Zp-UouW=UfqyaEd+3A3giXxRh8Q@mail.gmail.com>
Date: Wed, 4 Sep 2024 11:15:43 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Nathan Chancellor <nathan@...nel.org>, 
	Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH v2] kbuild: pahole-version: improve overall checking and
 error messages

On Tue, Sep 3, 2024 at 1:13 AM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Mon, Sep 2, 2024 at 6:09 PM Miguel Ojeda <ojeda@...nel.org> wrote:
> >
> > +if ! command -v "$@" >/dev/null; then
> > +       echo >&2 "***"
> > +       echo >&2 "*** pahole '$@' could not be found. pahole will not be used."
> > +       echo >&2 "***"
> > +       exit 1
> > +fi
>
> We may not want to print a warning in this case if this case/setup is
> too common, though.




I am fine with your color (in case someone wants
to run it manually?) as long as stderr is suppressed
in Kconfig.

default $(shell,$(srctree)/scripts/pahole-version.sh $(PAHOLE) 2>/dev/null)




scripts/rust_is_available.sh is very verbose, but
we are not annoyed while running Kconfig because the
$(success ) macro suppressed stderr.





-- 
Best Regards
Masahiro Yamada