linux-kernel - Re: [PATCH v2] kbuild: pahole-version: improve overall checking and error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQ5Y-FDUasJ9OJ50T3h=EUDPcnEmP1_QhDTSheViQiLrw@mail.gmail.com>
Date: Wed, 4 Sep 2024 11:23:14 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Nicolas Schier <nicolas@...sle.eu>, Miguel Ojeda <ojeda@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH v2] kbuild: pahole-version: improve overall checking and
 error messages

On Wed, Sep 4, 2024 at 9:15 AM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Tue, Sep 3, 2024 at 9:49 PM Nicolas Schier <nicolas@...sle.eu> wrote:
> >
> > thanks, no objections.
>
> Thanks for taking a look!
>
> > I'd rather like to have
> >
> >     output=$(echo "$output" | sed -nE 's/v([0-9]+)\.([0-9][0-9])/\1\2/p')
> >
> > here (thus, explicitly check against a two number subversion), so that
> > we can detect also versions like 1.100 or 2.1 and bail out.
>
> So I didn't change that here to avoid more changes in the same commit,
> but happy to do that if preferred.
>
> However, do we want to make it too strict? i.e. I don't think it is
> very unexpected to get v1.100 or v2.1 -- it may not be what current
> `pahole` does or ever do, but I am not sure we gain much by being so
> strict.


I am not sure whether pahole never releases v2.0


$ echo v2.0 | sed -nE 's/v([0-9]+)\.([0-9]+)/\1\2/p'
20


Not a syntax error, but the version comparison will not work correctly.








>
> (Similarly, for the ^..$ suggestion, it could be that `pahole` decides
> to to something like `pahole v1.25`, i.e. `name version`, like other
> programs).
>
> Either way, I am happy -- I doubt `pahole` changes too much, and if it
> does, we can change this too.
>
> Cheers,
> Miguel
>


-- 
Best Regards
Masahiro Yamada