linux-kernel - Re: [PATCH 02/18] drm/i915/selftests: Include <linux/prandom.h> instead of <linux/random.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871q1yqmgx.fsf@intel.com>
Date: Thu, 05 Sep 2024 16:06:06 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Uros Bizjak <ubizjak@...il.com>, linux-kernel@...r.kernel.org
Cc: Uros Bizjak <ubizjak@...il.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Tvrtko Ursulin <tursulin@...ulin.net>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, intel-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 02/18] drm/i915/selftests: Include <linux/prandom.h>
 instead of <linux/random.h>

On Thu, 05 Sep 2024, Uros Bizjak <ubizjak@...il.com> wrote:
> Usage of pseudo-random functions requires inclusion of
> <linux/prandom.h> header instead of <linux/random.h>.
>
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
> Cc: Tvrtko Ursulin <tursulin@...ulin.net>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: intel-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org

LGTM,

Acked-by: Jani Nikula <jani.nikula@...el.com>

for merging via whichever tree suits you best.

> ---
>  drivers/gpu/drm/i915/selftests/i915_gem.c    | 2 +-
>  drivers/gpu/drm/i915/selftests/i915_random.h | 2 +-
>  drivers/gpu/drm/i915/selftests/scatterlist.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
> index 61da4ed9d521..0727492576be 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
> @@ -4,7 +4,7 @@
>   * Copyright © 2018 Intel Corporation
>   */
>  
> -#include <linux/random.h>
> +#include <linux/prandom.h>
>  
>  #include "gem/i915_gem_internal.h"
>  #include "gem/i915_gem_pm.h"
> diff --git a/drivers/gpu/drm/i915/selftests/i915_random.h b/drivers/gpu/drm/i915/selftests/i915_random.h
> index 05364eca20f7..70330a2e80f2 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_random.h
> +++ b/drivers/gpu/drm/i915/selftests/i915_random.h
> @@ -26,7 +26,7 @@
>  #define __I915_SELFTESTS_RANDOM_H__
>  
>  #include <linux/math64.h>
> -#include <linux/random.h>
> +#include <linux/prandom.h>
>  
>  #include "../i915_selftest.h"
>  
> diff --git a/drivers/gpu/drm/i915/selftests/scatterlist.c b/drivers/gpu/drm/i915/selftests/scatterlist.c
> index 805c4bfb85fe..7e59591bbed6 100644
> --- a/drivers/gpu/drm/i915/selftests/scatterlist.c
> +++ b/drivers/gpu/drm/i915/selftests/scatterlist.c
> @@ -22,7 +22,7 @@
>   */
>  
>  #include <linux/prime_numbers.h>
> -#include <linux/random.h>
> +#include <linux/prandom.h>
>  
>  #include "i915_selftest.h"
>  #include "i915_utils.h"

-- 
Jani Nikula, Intel