linux-kernel - [PATCH] firewire: core: use WARN_ON_ONCE() to avoid superfluous dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240905131029.6433-1-o-takashi@sakamocchi.jp>
Date: Thu,  5 Sep 2024 22:10:29 +0900
From: Takashi Sakamoto <o-takashi@...amocchi.jp>
To: linux1394-devel@...ts.sourceforge.net
Cc: linux-kernel@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>
Subject: [PATCH] firewire: core: use WARN_ON_ONCE() to avoid superfluous dumps

It is enough to notify programming mistakes to programmers just once.

Suggested-by: Takashi Iwai <tiwai@...e.de>
Signed-off-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
---
 drivers/firewire/core-iso.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c
index af76fa1823f1..a249974a0f87 100644
--- a/drivers/firewire/core-iso.c
+++ b/drivers/firewire/core-iso.c
@@ -220,7 +220,7 @@ int fw_iso_context_flush_completions(struct fw_iso_context *ctx)
 	might_sleep();
 
 	// Avoid dead lock due to programming mistake.
-	if (WARN_ON(current_work() == &ctx->work))
+	if (WARN_ON_ONCE(current_work() == &ctx->work))
 		return 0;
 
 	disable_work_sync(&ctx->work);
@@ -244,7 +244,7 @@ int fw_iso_context_stop(struct fw_iso_context *ctx)
 	might_sleep();
 
 	// Avoid dead lock due to programming mistake.
-	if (WARN_ON(current_work() == &ctx->work))
+	if (WARN_ON_ONCE(current_work() == &ctx->work))
 		return 0;
 
 	err = ctx->card->driver->stop_iso(ctx);
-- 
2.43.0