linux-kernel - Re: [PATCH v1] mfd: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1da24d04-e99d-4b22-aec2-92d89d9cf089@microchip.com>
Date: Thu, 5 Sep 2024 16:35:18 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Shen Lichuan <shenlichuan@...o.com>, <lee@...nel.org>,
	<alexandre.belloni@...tlin.com>, <claudiu.beznea@...on.dev>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<opensource.kernel@...o.com>
Subject: Re: [PATCH v1] mfd: Convert comma to semicolon

On 05/09/2024 at 11:27, Shen Lichuan wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
>   drivers/mfd/atmel-flexcom.c | 2 +-
>   drivers/mfd/rk8xx-core.c    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index b52f7ffdad35..d5df5466eaf5 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -95,7 +95,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>          if (err)
>                  return err;
> 
> -       val = FLEX_MR_OPMODE(ddata->opmode),
> +       val = FLEX_MR_OPMODE(ddata->opmode);

It surely doesn't change the behavior, but it's probably a typo anyway:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com> #  for atmel-flexcom.c

Regards,
   Nicolas

>          writel(val, ddata->base + FLEX_MR);
> 
>          clk_disable_unprepare(ddata->clk);

[..]