linux-kernel - Re: dm integrity: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtnBjyn8eSygoaT1@kernel.org>
Date: Thu, 5 Sep 2024 10:34:55 -0400
From: Mike Snitzer <snitzer@...nel.org>
To: Chen Ni <nichen@...as.ac.cn>
Cc: agk@...hat.com, mpatocka@...hat.com, dm-devel@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: dm integrity: Convert comma to semicolon

On Thu, Sep 05, 2024 at 10:28:32AM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

I agree, the use of comma is bizarre.  Not sure how that slipped
through but...

Reviewed-by: Mike Snitzer <snitzer@...nel.org>