linux-kernel - Re: dm integrity: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6f3b1b0-130b-f83c-fca1-470d3116b08c@redhat.com>
Date: Fri, 6 Sep 2024 13:38:07 +0200 (CEST)
From: Mikulas Patocka <mpatocka@...hat.com>
To: Mike Snitzer <snitzer@...nel.org>
cc: Chen Ni <nichen@...as.ac.cn>, agk@...hat.com, dm-devel@...ts.linux.dev, 
    linux-kernel@...r.kernel.org
Subject: Re: dm integrity: Convert comma to semicolon



On Thu, 5 Sep 2024, Mike Snitzer wrote:

> On Thu, Sep 05, 2024 at 10:28:32AM +0800, Chen Ni wrote:
> > Replace comma between expressions with semicolons.
> > 
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> > 
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> > 
> > Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> 
> I agree, the use of comma is bizarre.  Not sure how that slipped
> through but...
> 
> Reviewed-by: Mike Snitzer <snitzer@...nel.org>

Applied, thanks.

I don't know why I used ',' there.

Mikulas