linux-kernel - Re: [PATCH v1 1/1] regulator: of: Refactor of_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcVd7Zn2ZBRzor=jo0z9CtLDfacW6WXSiGCro4v9=VddQ@mail.gmail.com>
Date: Thu, 5 Sep 2024 20:40:00 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Chen-Yu Tsai <wenst@...omium.org>
Cc: Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org, 
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v1 1/1] regulator: of: Refactor of_get_*regulator() to
 decrease indentation

On Thu, Sep 5, 2024 at 11:49 AM Chen-Yu Tsai <wenst@...omium.org> wrote:
> On Thu, Sep 5, 2024 at 3:09 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > Refactor of_get_*regulator() to decrease indentation and increase readability.
> > No functional changes intended.
> >
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
>
> Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>

Thank you!

...

> > -                               goto err_node_put;
>
> Nit: I would probably rename this to out_node_put. But if we're going to
> move to the scoped helper, we might as well just skip it.

It's a bit out of the scope of this patch. And yes, if we go in that
direction it doesn't really matter. It will be replaced by direct
return calls anyway.

-- 
With Best Regards,
Andy Shevchenko