linux-kernel - Re: [PATCH v4] clk: imx8qxp: Defer instead of failing probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e1436511cadbe5eb6e0b567d61f0cea.sboyd@kernel.org>
Date: Thu, 05 Sep 2024 11:35:54 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>, Diogo Manuel Pais Silva <diogo.pais@...ontrol.com>, Peng Fan <peng.fan@....com>
Cc: abelvesa@...nel.org <abelvesa@...nel.org>, linux-clk@...r.kernel.org <linux-clk@...r.kernel.org>, shawnguo@...nel.org <shawnguo@...nel.org>, kernel@...gutronix.de <kernel@...gutronix.de>, s.hauer@...gutronix.de <s.hauer@...gutronix.de>, linux-arm-kernel@...ts.infradead.org <linux-arm-kernel@...ts.infradead.org>, mturquette@...libre.com <mturquette@...libre.com>, festevam@...il.com <festevam@...il.com>, imx@...ts.linux.dev <imx@...ts.linux.dev>, EMC: linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>;
Subject: Re: [PATCH v4] clk: imx8qxp: Defer instead of failing probe

Quoting Diogo Manuel Pais Silva (2024-09-03 23:50:02)
> When of_clk_parent_fill is ran without all the parent clocks having been
> probed then the probe function will return -EINVAL, making it so that
> the probe isn't attempted again. As fw_devlink is on by default this
> does not usually happen, but if fw_devlink is disabled then it is very
> possible that the parent clock will be probed after the lpcg first
> attempt.
> 
> Signed-off-by: Diogo Silva <diogo.pais@...ontrol.com>
> ---

Please stop sending as replies to previous patches.

>  drivers/clk/imx/clk-imx8qxp-lpcg.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> index d0ccaa040225..1c3e1a7df8ca 100644
> --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
> +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> @@ -225,8 +225,8 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
> 
>         ret = of_clk_parent_fill(np, parent_names, count);

It would be better to move to struct clk_parent_data here and use the
.index member if possible. That would allow the clks to be registered
without their parent(s) being registered. It lets the core take care of
finding the parents.