lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <a7fd7490-53c9-4a25-a659-6f52ff509fe8@baylibre.com> Date: Thu, 5 Sep 2024 16:37:17 -0500 From: David Lechner <dlechner@...libre.com> To: Alexandru Ardelean <aardelean@...libre.com>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Cc: jic23@...nel.org, krzk+dt@...nel.org, robh@...nel.org, lars@...afoo.de, michael.hennerich@...log.com, gstols@...libre.com Subject: Re: [PATCH v4 2/8] iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct() On 9/5/24 3:23 AM, Alexandru Ardelean wrote: > The ad7606_scan_direct() function returns 'int', which is fine for 16-bit > samples. > But when going to 18-bit samples, these need to be implemented as 32-bit > (or int) type. > > In that case when getting samples (which can be negative), we'd get random > error codes. > So, the easiest thing is to just move the 'val' pointer to > 'ad7606_scan_direct()'. This doesn't qualify as a fix, it's just a > preparation for 18-bit ADCs (of the AD7606 family). > > Signed-off-by: Alexandru Ardelean <aardelean@...libre.com> > --- Reviewed-by: David Lechner <dlechner@...libre.com>
Powered by blists - more mailing lists