lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <3wz36hrpicogoakqhmveppcrt6s52zmlcgjpio3wwpil3rdwdi@ft7tloqqf2zt> Date: Thu, 5 Sep 2024 23:43:30 +0200 From: Andi Shyti <andi.shyti@...nel.org> To: Tyrone Ting <warp5tw@...il.com> Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com, venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com, andriy.shevchenko@...ux.intel.com, wsa@...nel.org, rand.sec96@...il.com, wsa+renesas@...g-engineering.com, tali.perry@...oton.com, Avi.Fishman@...oton.com, tomer.maimon@...oton.com, KWLIU@...oton.com, JJLIU0@...oton.com, kfting@...oton.com, openbmc@...ts.ozlabs.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 6/7] i2c: npcm: use i2c frequency table Hi, On Fri, Aug 30, 2024 at 11:46:39AM GMT, Tyrone Ting wrote: > Modify i2c frequency from table parameters > for NPCM i2c modules. > > Supported frequencies are: > > 1. 100KHz > 2. 400KHz > 3. 1MHz I agree with Andy, please add a good explanation for this change. > Signed-off-by: Tyrone Ting <kfting@...oton.com> > --- > drivers/i2c/busses/i2c-npcm7xx.c | 230 +++++++++++++++++++------------ > 1 file changed, 144 insertions(+), 86 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c > index 67d156ed29b9..cac4ea0b69b8 100644 > --- a/drivers/i2c/busses/i2c-npcm7xx.c > +++ b/drivers/i2c/busses/i2c-npcm7xx.c > @@ -263,6 +263,121 @@ static const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = { > #define I2C_FREQ_MIN_HZ 10000 > #define I2C_FREQ_MAX_HZ I2C_MAX_FAST_MODE_PLUS_FREQ > > +struct SMB_TIMING_T { Please run checkpatch.pl before sending the patches. Thanks, Andi
Powered by blists - more mailing lists