linux-kernel - Re: [PATCH v3 1/2] media: dt-bindings: Add ST VD56G3 camera sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29d74899-9651-4b73-8545-844dcdcb4aca@foss.st.com>
Date: Thu, 5 Sep 2024 09:58:22 +0200
From: Sylvain Petinot <sylvain.petinot@...s.st.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <benjamin.mugnier@...s.st.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <sakari.ailus@...ux.intel.com>, <linux-media@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <tomm.merciai@...il.com>, <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v3 1/2] media: dt-bindings: Add ST VD56G3 camera sensor

Hi Krzysztof,

Thanks for the review.

On 9/5/2024 8:41 AM, Krzysztof Kozlowski wrote:
> On Wed, Sep 04, 2024 at 04:52:37PM +0200, Sylvain Petinot wrote:
>> Add devicetree bindings Documentation for ST VD56G3 & ST VD66GY camera
>> sensors. Update MAINTAINERS file.
>>
> 
>> +            port {
>> +                endpoint {
>> +                    data-lanes = <1 2>;
>> +                    link-frequencies = /bits/ 64 <402000000>;
>> +                    remote-endpoint = <&csiphy0_ep>;
>> +                };
>> +            };
>> +        };
>> +    };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e6d77bea5db5..e58deb5b3047 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -21561,6 +21561,14 @@ S:	Maintained
>>  F:	Documentation/hwmon/stpddc60.rst
>>  F:	drivers/hwmon/pmbus/stpddc60.c
>>  
>> +ST VD56G3 IMAGE SENSOR DRIVER
>> +M:	Benjamin Mugnier <benjamin.mugnier@...s.st.com>
>> +M:	Sylvain Petinot <sylvain.petinot@...s.st.com>
>> +L:	linux-media@...r.kernel.org
>> +S:	Maintained
>> +F:	Documentation/devicetree/bindings/media/i2c/st,vd56g3.yaml
>> +F:	drivers/media/i2c/vd56g3.c
> 
> There is no such file.

My bad, fixed for V4.

> 
> 
>> +
>>  ST VGXY61 DRIVER
>>  M:	Benjamin Mugnier <benjamin.mugnier@...s.st.com>
>>  M:	Sylvain Petinot <sylvain.petinot@...s.st.com>
>> @@ -23947,6 +23955,7 @@ F:	drivers/media/i2c/mt*
>>  F:	drivers/media/i2c/og*
>>  F:	drivers/media/i2c/ov*
>>  F:	drivers/media/i2c/s5*
>> +F:	drivers/media/i2c/vd56g3.c
> 
> Neither this one.

Ditto

> 
> After fixing the paths:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof


--
Sylvain