[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1ac78d8a-c0dc-4f90-9e25-6d9569894670@gmail.com>
Date: Thu, 5 Sep 2024 10:01:11 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: Ma Ke <make24@...as.ac.cn>, nbd@....name, lorenzo@...nel.org,
ryder.lee@...iatek.com, shayne.chen@...iatek.com, sean.wang@...iatek.com,
kvalo@...nel.org, angelogioacchino.delregno@...labora.com,
ruanjinjie@...wei.com
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
stable@...r.kernel.org
Subject: Re: [PATCH] mt76: mt7615: check devm_kasprintf() returned value
On 05/09/2024 03:47, Ma Ke wrote:
> devm_kasprintf() can return a NULL pointer on failure but this returned
> value is not checked. Fix this lack and check the returned value.
>
> Found by code review.
>
> Cc: stable@...r.kernel.org
> Fixes: 0bb4e9187ea4 ("mt76: mt7615: fix hwmon temp sensor mem use-after-free")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
If you find more problems of that sort in the mediatek wireless drivers, I think
a better approach would be to send them all as one patch.
> ---
> drivers/net/wireless/mediatek/mt76/mt7615/init.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> index f7722f67db57..0b9ebdcda221 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> @@ -56,6 +56,9 @@ int mt7615_thermal_init(struct mt7615_dev *dev)
>
> name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7615_%s",
> wiphy_name(wiphy));
> + if (!name)
> + return -ENOMEM;
> +
> hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, dev,
> mt7615_hwmon_groups);
> return PTR_ERR_OR_ZERO(hwmon);
Powered by blists - more mailing lists