linux-kernel - Re: [PATCHv2 net-next 6/8] net: ibm: emac: use netdev's phydev directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5da52e7-6715-4f94-ba95-5453972d9f8d@redhat.com>
Date: Thu, 5 Sep 2024 12:10:39 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Rosen Penev <rosenp@...il.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 linux-kernel@...r.kernel.org, jacob.e.keller@...el.com, horms@...nel.org,
 sd@...asysnail.net, chunkeey@...il.com
Subject: Re: [PATCHv2 net-next 6/8] net: ibm: emac: use netdev's phydev
 directly

Hi,

On 9/3/24 21:42, Rosen Penev wrote:
> @@ -2622,26 +2618,28 @@ static int emac_dt_mdio_probe(struct emac_instance *dev)
>   static int emac_dt_phy_connect(struct emac_instance *dev,
>   			       struct device_node *phy_handle)
>   {
> +	struct phy_device *phy_dev = dev->ndev->phydev;

The above assignment looks confusing/not needed, as 'phy_dev' will be 
initialized a few line later and not used in between.

Cheers,

Paolo