lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2a44050f-89f8-446f-aa5f-3101ae46f314@redhat.com>
Date: Thu, 5 Sep 2024 12:12:06 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Rosen Penev <rosenp@...il.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 linux-kernel@...r.kernel.org, jacob.e.keller@...el.com, horms@...nel.org,
 sd@...asysnail.net, chunkeey@...il.com
Subject: Re: [PATCHv2 net-next 4/8] net: ibm: emac: remove mii_bus with devm

On 9/3/24 21:42, Rosen Penev wrote:
> diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
> index 459f893a0a56..4cf8af9052bf 100644
> --- a/drivers/net/ethernet/ibm/emac/core.c
> +++ b/drivers/net/ethernet/ibm/emac/core.c
> @@ -2580,6 +2580,7 @@ static const struct mii_phy_ops emac_dt_mdio_phy_ops = {
>   
>   static int emac_dt_mdio_probe(struct emac_instance *dev)
>   {
> +	struct mii_bus *bus;
>   	struct device_node *mii_np;
>   	int res;

Minor nit: please respect the reverse xmas tree above.

Thanks,

Paolo


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ