lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240906175430.389cf208@device-28.home> Date: Fri, 6 Sep 2024 17:54:30 +0200 From: Maxime Chevallier <maxime.chevallier@...tlin.com> To: Andrew Lunn <andrew@...n.ch> Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Florian Fainelli <f.fainelli@...il.com>, kernel@...gutronix.de, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Russell King <linux@...linux.org.uk>, devicetree@...r.kernel.org Subject: Re: [PATCH v1] dt-bindings: net: ethernet-phy: Add forced-master/slave properties for SPE PHYs On Fri, 6 Sep 2024 17:11:54 +0200 Andrew Lunn <andrew@...n.ch> wrote: [...] > 10Base-T1 often does not have autoneg, so preferred-master & > preferred-slave make non sense in this context, but i wounder if > somebody will want these later. An Ethernet switch is generally > preferred-master for example, but the client is preferred-slave. > > Maybe make the property a string with supported values 'forced-master' > and 'forced-slave', leaving it open for the other two to be added > later. My two cents, don't take it as a nack or any strong disagreement, my experience with SPE is still limited. I agree that for SPE, it's required that PHYs get their role assigned as early as possible, otherwise the link can't establish. I don't see any other place but DT to put that info, as this would be required for say, booting over the network. This to me falls under 'HW representation', as we could do the same with straps. However for preferred-master / preferred-slave, wouldn't we be crossing the blurry line of "HW description => system configuration in the DT" ? Maxime
Powered by blists - more mailing lists