linux-kernel - Re: [RFC PATCH 3/3] drm/log: Introduce a new boot logger to draw the kmsg on the screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c02de5fb-1daa-4afd-9887-96087ee4eb43@redhat.com>
Date: Fri, 6 Sep 2024 18:29:13 +0200
From: Jocelyn Falempe <jfalempe@...hat.com>
To: John Ogness <john.ogness@...utronix.de>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Javier Martinez Canillas <javierm@...hat.com>,
 "Guilherme G . Piccoli" <gpiccoli@...lia.com>,
 bluescreen_avenger@...izon.net, Petr Mladek <pmladek@...e.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 3/3] drm/log: Introduce a new boot logger to draw the
 kmsg on the screen

On 06/09/2024 10:47, John Ogness wrote:
> On 2024-09-06, John Ogness <john.ogness@...utronix.de> wrote:
>> Your device_lock()/device_unlock() callbacks probably just need to
>> lock/unlock your mutex @drm_log_lock.
> 
> Sorry, forgot to mention that the device_lock() callback must also
> disable migration. Since you are using a mutex, you will need to
> manually do that as well...
> 
> mutex_lock(&drm_log_lock);
> migrate_disable();

Thanks a lot, I've done most of the conversion, and it's already working 
great. I will send a new series next week.

Best regards,

-- 

Jocelyn

> 
> John
>