linux-kernel - Re: [PATCH v3 00/29] Qualcomm iris video decoder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c5a5d30-5ee0-4d5e-ab9f-a0277fe8796a@quicinc.com>
Date: Fri, 6 Sep 2024 09:28:54 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>
CC: <quic_dikshita@...cinc.com>, Vikash Garodia <quic_vgarodia@...cinc.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Vedang Nagar <quic_vnagar@...cinc.com>
Subject: Re: [PATCH v3 00/29] Qualcomm iris video decoder driver



On 9/1/2024 5:02 PM, Dmitry Baryshkov wrote:
> On Sat, Aug 31, 2024 at 04:18:35PM GMT, Bryan O'Donoghue wrote:
>>> The result of v4l2-compliance test on SM8250:
>>>
>>> v4l2-compliance 1.29.0-5239, 64 bits, 64-bit time_t
>>> v4l2-compliance SHA: a1ebb4dad512 2024-08-08 20:00:17
>>>
>>> Compliance test for iris_driver device /dev/video0:
>>>
>>> Driver Info:
>>>           Driver name      : iris_driver
>>>           Card type        : iris_decoder
>>
>> Hmm, so this is decoder only ?
>>
>> What's the intention here for encoding support ?
>>
>> I've verified your results on the test branch but I just noticed that sm8250
>> with the iris driver is decoder only - whereas the venus driver does both,
>> which strikes me as a bit odd.
> 
> I think we all have discussed this during the review of the previous
> series: complete driver becomes very huge and complicated to review. So
> the recommendation was to submit the limited features driver (decoding,
> 1 codec) and get more features (more codecs, encoding support, etc)
> after getting the Iris driver in. Of course sm8250 support in Venus
> driver will stay in until Iris driver reaches feature parity.
> 

Ack and +1 to this.

Lets first review and conclude on the driver with the limited feature 
set and incrementally build the driver to be feature compatible with 
venus as we had agreed upon earlier.

>>
>> Is your intention to publish more patches to enable the encoder in another
>> series ?
>>
>> ---
>> bod
>