linux-kernel - Re: [PATCH 08/15] mm/damon/core: Use generic upper bound recommondation for usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240906163141.31088-1-sj@kernel.org>
Date: Fri,  6 Sep 2024 09:31:41 -0700
From: SeongJae Park <sj@...nel.org>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc: SeongJae Park <sj@...nel.org>,
	Frederic Weisbecker <frederic@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jonathan Corbet <corbet@....net>,
	linux-kernel@...r.kernel.org,
	Len Brown <len.brown@...el.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	damon@...ts.linux.dev,
	linux-mm@...ck.org
Subject: Re: [PATCH 08/15] mm/damon/core: Use generic upper bound recommondation for usleep_range()

On Wed, 04 Sep 2024 15:04:58 +0200 Anna-Maria Behnsen <anna-maria@...utronix.de> wrote:

> The upper bound for usleep_range_idle() was taken from the outdated
> documentation. As a recommondation for the upper bound of usleep_range()
> depends on HZ configuration it is not possible to hard code it.
> 
> Use the define "USLEEP_RANGE_UPPER_BOUND" instead.
> 
> Cc: SeongJae Park <sj@...nel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: damon@...ts.linux.dev
> Cc: linux-mm@...ck.org
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

> ---
>  mm/damon/core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 94fe2f1f9b0e..4b971871da75 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -1883,8 +1883,7 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme)
>  
>  static void kdamond_usleep(unsigned long usecs)
>  {
> -	/* See Documentation/timers/timers-howto.rst for the thresholds */
> -	if (usecs > 20 * USEC_PER_MSEC)
> +	if (usecs >= USLEEP_RANGE_UPPER_BOUND)
>  		schedule_timeout_idle(usecs_to_jiffies(usecs));
>  	else
>  		usleep_range_idle(usecs, usecs + 1);
> 
> -- 
> 2.39.2
> 
>