linux-kernel - Re: [PATCH v2 RESEND] tpm: export tpm2_sessions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <603acd64-0a6d-470b-9c9b-f6146443dc0c@linux.ibm.com>
Date: Fri, 6 Sep 2024 13:02:37 -0400
From: Stefan Berger <stefanb@...ux.ibm.com>
To: Jarkko Sakkinen <jarkko@...nel.org>, Kexy Biscuit <kexybiscuit@...c.io>,
        linux-integrity@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org, mpe@...erman.id.au,
        naveen.n.rao@...ux.ibm.com, zohar@...ux.ibm.com,
        stable@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Mingcong Bai <jeffbai@...c.io>
Subject: Re: [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm
 building



On 9/5/24 10:26 AM, Jarkko Sakkinen wrote:
> On Thu Sep 5, 2024 at 11:52 AM EEST, Kexy Biscuit wrote:
>> Commit 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to
>> initialize session support") adds call to tpm2_sessions_init() in ibmvtpm,
>> which could be built as a module. However, tpm2_sessions_init() wasn't
>> exported, causing libmvtpm to fail to build as a module:
>>
>> ERROR: modpost: "tpm2_sessions_init" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
>>
>> Export tpm2_sessions_init() to resolve the issue.
>>
>> Cc: stable@...r.kernel.org # v6.10+
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202408051735.ZJkAPQ3b-lkp@intel.com/
>> Fixes: 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support")
>> Signed-off-by: Kexy Biscuit <kexybiscuit@...c.io>
>> Signed-off-by: Mingcong Bai <jeffbai@...c.io>
>> ---
>> V1 -> V2: Added Fixes tag and fixed email format
>> RESEND: The previous email was sent directly to stable-rc review
>>
>>   drivers/char/tpm/tpm2-sessions.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
>> index d3521aadd43e..44f60730cff4 100644
>> --- a/drivers/char/tpm/tpm2-sessions.c
>> +++ b/drivers/char/tpm/tpm2-sessions.c
>> @@ -1362,4 +1362,5 @@ int tpm2_sessions_init(struct tpm_chip *chip)
>>   
>>   	return rc;
>>   }
>> +EXPORT_SYMBOL(tpm2_sessions_init);
>>   #endif /* CONFIG_TCG_TPM2_HMAC */
> 
> Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> 
Would have tested it but machine is down..

Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>

> BR, Jarkko
>