linux-kernel - Re: [PATCH] fou: fix initialization of grc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240906170636.69739-1-kuniyu@amazon.com>
Date: Fri, 6 Sep 2024 10:06:36 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <usama.anjum@...labora.com>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<kernel@...labora.com>, <kuba@...nel.org>, <kuniyu@...zon.com>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH] fou: fix initialization of grc

From: Muhammad Usama Anjum <usama.anjum@...labora.com>
Date: Fri,  6 Sep 2024 15:28:39 +0500
> The grc must be initialize first. There can be a condition where if
> fou is NULL, goto out will be executed and grc would be used
> uninitialized.
> 
> Fixes: 7e4196935069 ("fou: Fix null-ptr-deref in GRO.")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Thanks!


> ---
>  net/ipv4/fou_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/fou_core.c b/net/ipv4/fou_core.c
> index 78b869b314921..3e30745e2c09a 100644
> --- a/net/ipv4/fou_core.c
> +++ b/net/ipv4/fou_core.c
> @@ -336,11 +336,11 @@ static struct sk_buff *gue_gro_receive(struct sock *sk,
>  	struct gro_remcsum grc;
>  	u8 proto;
>  
> +	skb_gro_remcsum_init(&grc);
> +
>  	if (!fou)
>  		goto out;
>  
> -	skb_gro_remcsum_init(&grc);
> -
>  	off = skb_gro_offset(skb);
>  	len = off + sizeof(*guehdr);
>  
> -- 
> 2.39.2