linux-kernel - Re: [PATCH] PCI: brcmstb: Correctly store and use the output value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+-6iNw1PCNL6k3bx18VySbgt8m2tjOMokqC-esDfHaSN-dh0A@mail.gmail.com>
Date: Fri, 6 Sep 2024 14:20:09 -0400
From: Jim Quinlan <james.quinlan@...adcom.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Jim Quinlan <jim2101024@...il.com>, Nicolas Saenz Julienne <nsaenz@...nel.org>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kw@...ux.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Rob Herring <robh@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Stanimir Varbanov <svarbanov@...e.de>, kernel@...labora.com, 
	Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, 
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: brcmstb: Correctly store and use the output value

On Fri, Sep 6, 2024 at 7:10 AM Muhammad Usama Anjum
<usama.anjum@...labora.com> wrote:
>
> brcm_pcie_get_inbound_wins() can return negative error. As
> num_inbound_wins is unsigned, we'll be unable to recognize the error.
> Hence store return value of brcm_pcie_get_inbound_wins() in ret which is
> signed and store result back to num_inbound_wins after confirming that
> it isn't negative.


Hello Muhammad,
You are correct -- I was asked to make a few variables to be of the
type u8, but I missed having an int (ret) hold the
resultof that call. I believe I am still in the process of submitting
this commit series -- V7 is coming next -- so I will
take your email as a review instead of adding a fixup commit.

Unless Bjorn says that V6 was applied.

Thanks and regards,
Jim Quinlan
Broadcom STB/CM
>
>
> Fixes: 46c981fd60de ("PCI: brcmstb: Refactor for chips with many regular inbound windows")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---
>  drivers/pci/controller/pcie-brcmstb.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 55311dc47615d..054810d7962d7 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -1090,9 +1090,10 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie)
>         u32p_replace_bits(&tmp, 1, PCIE_MISC_MISC_CTRL_PCIE_RCB_64B_MODE_MASK);
>         writel(tmp, base + PCIE_MISC_MISC_CTRL);
>
> -       num_inbound_wins = brcm_pcie_get_inbound_wins(pcie, inbound_wins);
> -       if (num_inbound_wins < 0)
> -               return num_inbound_wins;
> +       ret = brcm_pcie_get_inbound_wins(pcie, inbound_wins);
> +       if (ret < 0)
> +               return ret;
> +       num_inbound_wins = (u8)ret;
>
>         set_inbound_win_registers(pcie, inbound_wins, num_inbound_wins);
>
> --
> 2.39.2
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4210 bytes)