linux-kernel - Re: [PATCH] PCI: brcmstb: Correctly store and use the output value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eeebe625-244d-48b7-9e48-2d26460127c6@broadcom.com>
Date: Fri, 6 Sep 2024 11:53:53 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Jim Quinlan <james.quinlan@...adcom.com>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Jim Quinlan <jim2101024@...il.com>,
 Nicolas Saenz Julienne <nsaenz@...nel.org>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Stanimir Varbanov <svarbanov@...e.de>, kernel@...labora.com,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: brcmstb: Correctly store and use the output value

On 9/6/24 11:20, Jim Quinlan wrote:
> On Fri, Sep 6, 2024 at 7:10 AM Muhammad Usama Anjum
> <usama.anjum@...labora.com> wrote:
>>
>> brcm_pcie_get_inbound_wins() can return negative error. As
>> num_inbound_wins is unsigned, we'll be unable to recognize the error.
>> Hence store return value of brcm_pcie_get_inbound_wins() in ret which is
>> signed and store result back to num_inbound_wins after confirming that
>> it isn't negative.
> 
> 
> Hello Muhammad,
> You are correct -- I was asked to make a few variables to be of the
> type u8, but I missed having an int (ret) hold the
> resultof that call. I believe I am still in the process of submitting
> this commit series -- V7 is coming next -- so I will
> take your email as a review instead of adding a fixup commit.
> 
> Unless Bjorn says that V6 was applied.

A similar patch has already been submitted to address this in a slightly 
different way:

https://lore.kernel.org/all/20240904161953.46790-2-riyandhiman14@gmail.com/
-- 
Florian