linux-kernel - Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cylgehr5.fsf@trenco.lwn.net>
Date: Fri, 06 Sep 2024 12:53:18 -0600
From: Jonathan Corbet <corbet@....net>
To: Abdul Rahim <abdul.rahim@...ahoo.com>, Bjorn Helgaas <helgaas@...nel.org>
Cc: bhelgaas@...gle.com, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-doc@...r.kernel.org,
 abdul.rahim@...ahoo.com
Subject: Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst

Abdul Rahim <abdul.rahim@...ahoo.com> writes:

> On Fri, Sep 06, 2024 at 11:41:52AM GMT, Bjorn Helgaas wrote:
>> On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote:
>> > Fixed spelling and edited for clarity.
>> > 
>> > Signed-off-by: Abdul Rahim <abdul.rahim@...ahoo.com>
>> > ---
>> >  Documentation/PCI/pci.rst | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > 
>> > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst
>> > index dd7b1c0c21da..344c2c2d94f9 100644
>> > --- a/Documentation/PCI/pci.rst
>> > +++ b/Documentation/PCI/pci.rst
>> > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization:
>> >    - Enable DMA/processing engines
>> >  
>> >  When done using the device, and perhaps the module needs to be unloaded,
>> > -the driver needs to take the follow steps:
>> > +the driver needs to perform the following steps:
>> 
>> I don't see a spelling fix here, and personally I wouldn't bother with
>> changing "take" to "perform" unless we have other more significant
>> changes to make at the same time.
>
> - "follow" has been corrected to "following", which is more appriopriate
> in this context.
> - I know its trivial, but can disturb the readers flow
> - do you want me to change the message to "Edited for clarity"

The problem is not s/follow/following/, it is the other, unrelated
change you made that does not improve the text.  There are reasons why
we ask people not to mix multiple changes.  If you submit just the
"following" fix, it will surely be applied.

Thanks,

jon