linux-kernel - Re: [PATCH v3 1/2] crypto: qcom-rng: fix support for ACPI-based systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hxemor5teajfz4a6ouv27baepjv6uxj5o5e74kynhizqgdi5gl@p55iombm5rgd>
Date: Fri, 6 Sep 2024 03:44:12 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Brian Masney <bmasney@...hat.com>
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, 
	quic_omprsing@...cinc.com, neil.armstrong@...aro.org, quic_bjorande@...cinc.com, 
	linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, 
	ernesto.mnd.fernandez@...il.com, quic_jhugo@...cinc.com
Subject: Re: [PATCH v3 1/2] crypto: qcom-rng: fix support for ACPI-based
 systems

On Thu, Sep 05, 2024 at 08:25:20PM GMT, Brian Masney wrote:
> The qcom-rng driver supports both ACPI and device tree-based systems.
> ACPI support was broken when the hw_random interface support was added.
> Let's go ahead and fix this by adding the appropriate driver data to the
> ACPI match table, and change the of_device_get_match_data() call to
> device_get_match_data() so that it will also work on ACPI-based systems.
> 
> This fix was boot tested on a Qualcomm Amberwing server (ACPI based) and
> on a Qualcomm SA8775p Automotive Development Board (DT based). I also
> verified that qcom-rng shows up in /proc/crypto on both systems.
> 
> Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
> Reported-by: Ernesto A. Fern??ndez <ernesto.mnd.fernandez@...il.com>
> Closes: https://lore.kernel.org/linux-arm-msm/20240828184019.GA21181@eaf/
> Cc: stable@...r.kernel.org
> Signed-off-by: Brian Masney <bmasney@...hat.com>
> ---
>  drivers/crypto/qcom-rng.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

-- 
With best wishes
Dmitry