lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <6to5p2dgsu6pvebkmkliojv5kfhnairigd46tmbraimxij7ddu@h6ziv7uwjeeq> Date: Fri, 6 Sep 2024 03:49:06 +0300 From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> To: Miaoqing Pan <quic_miaoqing@...cinc.com>, ath11k@...ts.infradead.org Cc: Dmitry Baryshkov <dbaryshkov@...il.com>, linux-arm-msm@...r.kernel.org, linux-media@...r.kernel.org, agross@...nel.org, andersson@...nel.org, linux-kernel@...r.kernel.org, konrad.dybcio@...aro.org, mchehab@...nel.org, quic_vgarodia@...cinc.com, stanimir.k.varbanov@...il.com, Kalle Valo <kvalo@...nel.org> Subject: Re: [PATCH] arm64: dts: qcom: sa8775p-ride: add WiFi/BT nodes On Fri, Sep 06, 2024 at 08:19:28AM GMT, Miaoqing Pan wrote: > > > On 9/5/2024 8:49 PM, Dmitry Baryshkov wrote: > > On Thu, Sep 05, 2024 at 02:48:17PM GMT, Miaoqing Pan wrote: > > > Add a node for the PMU module of the WCN6855 present on the sa8775p-ride > > > board. Assign its LDO power outputs to the existing WiFi/Bluetooth module. > > > > > > Signed-off-by: Miaoqing Pan <quic_miaoqing@...cinc.com> > > > --- > > > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 119 +++++++++++++++++++++ > > > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +- > > > 2 files changed, 120 insertions(+), 1 deletion(-) > > > > > > @@ -837,3 +939,20 @@ &usb_2_hsphy { > > > &xo_board_clk { > > > clock-frequency = <38400000>; > > > }; > > > + > > > +&pcieport0 { > > > + wifi@0 { > > > + compatible = "pci17cb,1101"; > > > + reg = <0x10000 0x0 0x0 0x0 0x0>; > > > + > > > + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > > > + vddaon-supply = <&vreg_pmu_aon_0p59>; > > > + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > > > + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > > > + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > > > + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > > > + vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>; > > > + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; > > > + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; > > > > Please add > > > > qcom,ath11k-calibration-variant = "name"; > > No need, here the WiFi node is for 'drivers/pci/pwrctl', not ath11k driver. NAK, nodes describe hardware, not drivers. And we have had enough issues with the WCN wifi having collisions on the board-id / chip-id / etc. Maybe we should make calibration-data required for the DT-based systems? Kalle, WDYT? -- With best wishes Dmitry
Powered by blists - more mailing lists