linux-kernel - Re: [PATCH v1] drivers:drm:exynos_drm_gsc:Fix wrong assignment in gsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAQKjZPAbXDCXafBfrjcxt+=P0C-SYT_NDf5hjeJkpOvawYaag@mail.gmail.com>
Date: Fri, 6 Sep 2024 16:13:55 +0900
From: Inki Dae <daeinki@...il.com>
To: Yuesong Li <liyuesong@...o.com>
Cc: sw0312.kim@...sung.com, kyungmin.park@...sung.com, airlied@...il.com, 
	daniel@...ll.ch, krzk@...nel.org, alim.akhtar@...sung.com, 
	dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:drm:exynos_drm_gsc:Fix wrong assignment in gsc_bind()

Hi Yuesong Li,

2024년 8월 22일 (목) 오후 6:09, Yuesong Li <liyuesong@...o.com>님이 작성:
>
> cocci reported a double assignment problem. Upon reviewing previous
> commits, it appears this may actually be an incorrect assignment.
>
> Fixes: 8b9550344d39 ("drm/ipp: clean up debug messages")
> Signed-off-by: Yuesong Li <liyuesong@...o.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
> index 1b111e2c3347..752339d33f39 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
> @@ -1174,7 +1174,7 @@ static int gsc_bind(struct device *dev, struct device *master, void *data)
>         struct exynos_drm_ipp *ipp = &ctx->ipp;
>
>         ctx->drm_dev = drm_dev;
> -       ctx->drm_dev = drm_dev;
> +       ipp->drm_dev = drm_dev;

Correct. drm_dev should be set to ipp->drm_dev like other sub modules
of ipp - fimc, scaler and rotator - did.

Applied. Thanks,
Inki Dae

>         exynos_drm_register_dma(drm_dev, dev, &ctx->dma_priv);
>
>         exynos_drm_ipp_register(dev, ipp, &ipp_funcs,
> --
> 2.34.1
>
>