linux-kernel - Re:[PATCH] drm/rockchip: include rockchip_drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240906091728.109570-1-minhuadotchen@gmail.com>
Date: Fri,  6 Sep 2024 17:17:25 +0800
From: Min-Hua Chen <minhuadotchen@...il.com>
To: andyshrk@....com
Cc: airlied@...il.com,
	andy.yan@...k-chips.com,
	daniel@...ll.ch,
	dri-devel@...ts.freedesktop.org,
	heiko@...ech.de,
	hjc@...k-chips.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	maarten.lankhorst@...ux.intel.com,
	minhuadotchen@...il.com,
	mripard@...nel.org,
	tzimmermann@...e.de
Subject: Re:[PATCH] drm/rockchip: include rockchip_drm_drv.h

Hi,

>Hi  Min Hua，
>   Thanks for your work
>
>At 2024-09-06 06:38:50, "Min-Hua Chen" <minhuadotchen@...il.com> wrote:
>>Include rockchip_drm_drv.h to fix the follow sparse warning:
>>
>>drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse:
>>warning: symbol 'vop2_platform_driver' was not declared.
>>Should it be static?
>>
>>No functional change intended.
>>
>>Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>
>>---
>> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>>diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>>index 18efb3fe1c00..c678d1b0fd7c 100644
>>--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>>+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>>@@ -14,6 +14,7 @@
>> #include <drm/drm_print.h>
>> 
>> #include "rockchip_drm_vop2.h"
>>+#include "rockchip_drm_drv.h"
>> 
>
>We already have a patch[0] include rockchip_drm_drv.h in rockchip_drm_vop2.h
>
>[0]https://patchwork.kernel.org/project/linux-rockchip/patch/20240904120238.3856782-3-andyshrk@163.com/ 

that's great, thanks for letting me know.

Min-Hua