linux-kernel - Re: [PATCH net-next v4 3/5] net: ti: icssg-prueth: Add support for HSR frame forward offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202409061658.vSwcFJiK-lkp@intel.com>
Date: Fri, 6 Sep 2024 17:22:29 +0800
From: kernel test robot <lkp@...el.com>
To: MD Danish Anwar <danishanwar@...com>,
	Jan Kiszka <jan.kiszka@...mens.com>, Andrew Lunn <andrew@...n.ch>,
	Dan Carpenter <error27@...il.com>,
	Sai Krishna <saikrishnag@...vell.com>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>,
	Diogo Ivo <diogo.ivo@...mens.com>, Simon Horman <horms@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	srk@...com, Vignesh Raghavendra <vigneshr@...com>,
	Roger Quadros <rogerq@...nel.org>, danishanwar@...com
Subject: Re: [PATCH net-next v4 3/5] net: ti: icssg-prueth: Add support for
 HSR frame forward offload

Hi MD,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 075e3d30e4a3da8eadd12f2f063dc8e2ea9e1f08]

url:    https://github.com/intel-lab-lkp/linux/commits/MD-Danish-Anwar/net-ti-icss-iep-Move-icss_iep-structure/20240904-180917
base:   075e3d30e4a3da8eadd12f2f063dc8e2ea9e1f08
patch link:    https://lore.kernel.org/r/20240904100506.3665892-4-danishanwar%40ti.com
patch subject: [PATCH net-next v4 3/5] net: ti: icssg-prueth: Add support for HSR frame forward offload
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240906/202409061658.vSwcFJiK-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240906/202409061658.vSwcFJiK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409061658.vSwcFJiK-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/ti/icssg/icssg_prueth.c: In function 'emac_ndo_set_features':
>> drivers/net/ethernet/ti/icssg/icssg_prueth.c:765:24: warning: unused variable 'prueth' [-Wunused-variable]
     765 |         struct prueth *prueth = emac->prueth;
         |                        ^~~~~~


vim +/prueth +765 drivers/net/ethernet/ti/icssg/icssg_prueth.c

   760	
   761	static int emac_ndo_set_features(struct net_device *ndev,
   762					 netdev_features_t features)
   763	{
   764		struct prueth_emac *emac = netdev_priv(ndev);
 > 765		struct prueth *prueth = emac->prueth;
   766	
   767		emac_change_hsr_feature(ndev, features, NETIF_F_HW_HSR_FWD);
   768		emac_change_hsr_feature(ndev, features, NETIF_F_HW_HSR_DUP);
   769		emac_change_hsr_feature(ndev, features, NETIF_F_HW_HSR_TAG_INS);
   770		emac_change_hsr_feature(ndev, features, NETIF_F_HW_HSR_TAG_RM);
   771	
   772		return 0;
   773	}
   774	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki