linux-kernel - Re: [PATCH 2/2] media: venus: firmware: Use iommu_paging_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6d5490e-7270-4391-b91a-72af551c6e7d@suse.de>
Date: Fri, 6 Sep 2024 12:51:08 +0300
From: Stanimir Varbanov <svarbanov@...e.de>
To: Jason Gunthorpe <jgg@...dia.com>,
 Stanimir Varbanov <stanimir.k.varbanov@...il.com>
Cc: Lu Baolu <baolu.lu@...ux.intel.com>, Dmitry Osipenko <digetx@...il.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>, Joerg Roedel <joro@...tes.org>,
 Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
 Kevin Tian <kevin.tian@...el.com>, linux-media@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] media: venus: firmware: Use
 iommu_paging_domain_alloc()

Hi Jason,

On 9/4/24 15:16, Jason Gunthorpe wrote:
> On Tue, Aug 20, 2024 at 11:43:50PM +0300, Stanimir Varbanov wrote:
>> Hi,
>>
>> Thank you for the patch!
>>
>> On 12.08.24 г. 10:21 ч., Lu Baolu wrote:
>>> An iommu domain is allocated in venus_firmware_init() and is attached to
>>> core->fw.dev in the same function. Use iommu_paging_domain_alloc() to
>>> make it explicit.
>>>
>>> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
>>> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
>>> Link: https://lore.kernel.org/r/20240610085555.88197-10-baolu.lu@linux.intel.com
>>> ---
>>>   drivers/media/platform/qcom/venus/firmware.c | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
>>> index fe7da2b30482..66a18830e66d 100644
>>> --- a/drivers/media/platform/qcom/venus/firmware.c
>>> +++ b/drivers/media/platform/qcom/venus/firmware.ced
>>
>> Acked-by: Stanimir Varbanov <stanimir.k.varbanov@...il.com>
>>
>> I'll take the patch through linux-media tree.
> 
> Did this patch and the 1/2:

2/2 is in linux-next now.

~Stan