linux-kernel - Re:Re: [PATCH] drm/rockchip: include rockchip_drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4ca4ac.a3fb.191c6bde766.Coremail.andyshrk@163.com>
Date: Fri, 6 Sep 2024 17:50:20 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Diederik de Haas" <didi.debian@...ow.org>
Cc: "Min-Hua Chen" <minhuadotchen@...il.com>, "Sandy Huang" <hjc@...k-chips.com>, 
	Heiko Stübner <heiko@...ech.de>, 
	"Andy Yan" <andy.yan@...k-chips.com>, 
	"Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>, 
	"Maxime Ripard" <mripard@...nel.org>, 
	"Thomas Zimmermann" <tzimmermann@...e.de>, 
	"David Airlie" <airlied@...il.com>, 
	"Daniel Vetter" <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org, 
	linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h



Hi，
At 2024-09-06 17:28:33, "Diederik de Haas" <didi.debian@...ow.org> wrote:
>On Fri Sep 6, 2024 at 2:42 AM CEST, Andy Yan wrote:
>> At 2024-09-06 06:38:50, "Min-Hua Chen" <minhuadotchen@...il.com> wrote:
>> >Include rockchip_drm_drv.h to fix the follow sparse warning:
>> >
>> >drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse:
>> >warning: symbol 'vop2_platform_driver' was not declared.
>> >Should it be static?
>> >
>> >No functional change intended.
>> >
>> >Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>
>> >---
>> > drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> >diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> >index 18efb3fe1c00..c678d1b0fd7c 100644
>> >--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> >+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> >@@ -14,6 +14,7 @@
>> > #include <drm/drm_print.h>
>> > 
>> > #include "rockchip_drm_vop2.h"
>> >+#include "rockchip_drm_drv.h"
>> > 
>>
>> We already have a patch[0] include rockchip_drm_drv.h in rockchip_drm_vop2.h
>>
>> [0]https://patchwork.kernel.org/project/linux-rockchip/patch/20240904120238.3856782-3-andyshrk@163.com/ 
>
>Maybe I'm missing something, but this patch seems to fix an already
>existing bug (which should have a Fixes tag?), which Andy also fixed

>while implementing a different (and unrelated) feature?


In fact, I don't know how to reproduce this compilation issue.
While implementing my feature, I happened to find that I need to include rockchip_drm_drv.h in rockchip_drm_vop2.h



>
>Cheers,
>  Diederik