lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e985a9d4-b398-4290-a4b9-08999c6a9f71@kernel.org> Date: Fri, 6 Sep 2024 11:56:27 +0200 From: Krzysztof Kozlowski <krzk@...nel.org> To: Thippeswamy Havalige <thippesw@....com>, manivannan.sadhasivam@...aro.org, robh@...nel.org, linux-pci@...r.kernel.org, bhelgaas@...gle.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org Cc: bharat.kumar.gogada@....com, michal.simek@....com, lpieralisi@...nel.org, kw@...ux.com Subject: Re: [PATCH 1/2] dt-bindings: PCI: xilinx-cpm: Add compatible string for CPM5 controller-1. On 06/09/2024 11:31, Thippeswamy Havalige wrote: > The Xilinx Versal premium series has CPM5 block which supports two typeA > Root Port controller functionality at Gen5 speed. > > Add compatible string to distinguish between two CPM5 rootport controller1. Subjects NEVER end with full stops. > > Error interrupt register and bits for both the controllers > are at different. > > Signed-off-by: Thippeswamy Havalige <thippesw@....com> > --- > Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > index 989fb0fa2577..b63a759ec2d7 100644 > --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > @@ -17,6 +17,7 @@ properties: > enum: > - xlnx,versal-cpm-host-1.00 > - xlnx,versal-cpm5-host > + - xlnx,versal-cpm5-host1 That's poor naming. "-1.00" and now "1". Get your naming reasonable... Best regards, Krzysztof
Powered by blists - more mailing lists