linux-kernel - Re: [PATCH v2] dpaa2-switch: fix flooding domain among multiple vlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wtdu5gfrg3drgobwejrpv3gyl4x2wnnskzjavynlcmjawtcmio@kfrz7anzohmm>
Date: Fri, 6 Sep 2024 12:57:39 +0300
From: Ioana Ciornei <ioana.ciornei@....com>
To: junjie.wan@...eptio.ai
Cc: "'David S. Miller'" <davem@...emloft.net>, 
	'Eric Dumazet' <edumazet@...gle.com>, 'Jakub Kicinski' <kuba@...nel.org>, 
	'Paolo Abeni' <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dpaa2-switch: fix flooding domain among multiple vlans

On Thu, Sep 05, 2024 at 02:15:53PM +0800, junjie.wan@...eptio.ai wrote:
> Hi Ioana,
> 

(...)
> 
> I want to check one thing first with you. For dpsw, a 'standalone' interface is not usable, right?
> It is just in a state 'standalone' and needs more configurations before we use it for forwarding.
> If this is the case, can we just assign all standalone interfaces to a single FDB. Or even no FDB
> before they join a bridge. And if there are no VLANs assigned to any port, bridge should
> create a shared FDB for them.  So num of FDB is associated with VLAN rather than interfaces.
> 

When a DPSW interface in not under a bridge it behaves just as a regular
network interface, no forwarding. This is the default behavior for any
switch interface in Linux which is not under a bridge, it's not just the
dpaa2-switch driver which does it.

We cannot use the same FDB for all switch interfaces which are
'standalone' since this would basically mean that they can do forwarding
between them, which is exactly what we do not want.

> >
> > Maybe the changes around the FDB dump could be in a different patch?
> >
> > Ioana
> 
> Sure, Let me split it. But I'm going to have a two-week vacation from tomorrow. 
> During this period, I can't work on the patch. You will have to wait a bit long before I return
> back to the office. Or if you like, please send a new patch for this as you wish. 
> 

Not a problem. Have a great time in your vacation. We can continue when
you get back. Also, please feel free to contact me directly so that we
can sync and maybe test any potential patches before actually submitting
them.

Regards,
Ioana