[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a33633be-800c-4ca0-9d1e-f190e23384d5@roeck-us.net>
Date: Fri, 6 Sep 2024 04:41:05 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Junhao Xie <bigfoot@...ssfun.cn>, devicetree@...r.kernel.org,
linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, linux-pm@...r.kernel.org,
linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Cc: Jean Delvare <jdelvare@...e.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Pavel Machek <pavel@....cz>,
Lee Jones <lee@...nel.org>, Sebastian Reichel <sre@...nel.org>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>, Heiko Stuebner <heiko@...ech.de>,
Chukun Pan <amadeus@....edu.cn>
Subject: Re: [PATCH 6/9] hwmon: Add support for Photonicat PMU board
temperature sensor
On 9/6/24 02:36, Junhao Xie wrote:
> Photonicat PMU MCU will send status reports regularly,
> including board temperature.
>
This is not an appropriate description.
> Signed-off-by: Junhao Xie <bigfoot@...ssfun.cn>
> ---
> drivers/hwmon/Kconfig | 10 +++
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/photonicat-hwmon.c | 129 +++++++++++++++++++++++++++++++
Documentation missing.
> +static int pcat_hwmon_probe(struct platform_device *pdev)
> +{
...
> + dev_info(dev, "Board Temprature: %d degress C\n", hwmon->temperature);
> +
Unacceptable (misspelled) noise.
> + hwmon->hwmon = devm_hwmon_device_register_with_groups(
> + dev, label, hwmon, pcat_pmu_temp_groups);
> +
Please use the with_info API. I am not going to review the code because
it will need to be completely rewritten.
Guenter
Powered by blists - more mailing lists