lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1d86a38b-dd57-48ac-875b-4d9d2f645d47@arm.com> Date: Fri, 6 Sep 2024 12:41:11 +0100 From: Vincenzo Frascino <vincenzo.frascino@....com> To: Arnd Bergmann <arnd@...db.de>, Christophe Leroy <christophe.leroy@...roup.eu>, linux-kernel@...r.kernel.org, Linux-Arch <linux-arch@...r.kernel.org>, linux-mm@...ck.org Cc: Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, "Jason A . Donenfeld" <Jason@...c4.com>, Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Naveen N Rao <naveen@...nel.org>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>, Theodore Ts'o <tytso@....edu>, Andrew Morton <akpm@...ux-foundation.org>, Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com> Subject: Re: [PATCH 5/9] vdso: Split linux/minmax.h On 04/09/2024 18:23, Arnd Bergmann wrote: > On Wed, Sep 4, 2024, at 17:17, Christophe Leroy wrote: >> Le 03/09/2024 à 17:14, Vincenzo Frascino a écrit : >>> The VDSO implementation includes headers from outside of the >>> vdso/ namespace. >>> >>> Split linux/minmax.h to make sure that the generic library >>> uses only the allowed namespace. >> >> It is probably easier to just don't use min_t() in VDSO. Can be open >> coded without impeeding readability. > > Right, or possibly the even simpler MIN()/MAX() if the arguments > have no side-effects. > Agreed, generally I do not like open-coding since it tends to introduce duplication, but these cases are simple especially if we can use MIN()/MAX(). > Arnd -- Regards, Vincenzo
Powered by blists - more mailing lists