[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202409080407.JLfgI8Fr-lkp@intel.com>
Date: Sun, 8 Sep 2024 04:16:02 +0800
From: kernel test robot <lkp@...el.com>
To: Vasileios Amoiridis <vassilisamir@...il.com>, robh@...nel.org,
saravanak@...gle.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
andriy.shevchenko@...ux.intel.com,
Vasileios Amoiridis <vassilisamir@...il.com>
Subject: Re: [PATCH v2 2/2] of/irq: Use helper to define resources
Hi Vasileios,
kernel test robot noticed the following build errors:
[auto build test ERROR on ecc768a84f0b8e631986f9ade3118fa37852fef0]
url: https://github.com/intel-lab-lkp/linux/commits/Vasileios-Amoiridis/of-irq-Make-use-of-irq_get_trigger_type/20240905-000607
base: ecc768a84f0b8e631986f9ade3118fa37852fef0
patch link: https://lore.kernel.org/r/20240904160239.121301-3-vassilisamir%40gmail.com
patch subject: [PATCH v2 2/2] of/irq: Use helper to define resources
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240908/202409080407.JLfgI8Fr-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240908/202409080407.JLfgI8Fr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409080407.JLfgI8Fr-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/of/irq.c:432:71: error: expected ';' after expression
432 | *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev))
| ^
| ;
1 error generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
Selected by [y]:
- TI_K3_M4_REMOTEPROC [=y] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])
vim +432 drivers/of/irq.c
405
406 /**
407 * of_irq_to_resource - Decode a node's IRQ and return it as a resource
408 * @dev: pointer to device tree node
409 * @index: zero-based index of the irq
410 * @r: pointer to resource structure to return result into.
411 */
412 int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
413 {
414 int irq = of_irq_get(dev, index);
415
416 if (irq < 0)
417 return irq;
418
419 /* Only dereference the resource if both the
420 * resource and the irq are valid. */
421 if (r && irq) {
422 const char *name = NULL;
423
424 memset(r, 0, sizeof(*r));
425 /*
426 * Get optional "interrupt-names" property to add a name
427 * to the resource.
428 */
429 of_property_read_string_index(dev, "interrupt-names", index,
430 &name);
431
> 432 *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev))
433 r->flags |= irq_get_trigger_type(irq);
434 }
435
436 return irq;
437 }
438 EXPORT_SYMBOL_GPL(of_irq_to_resource);
439
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists