[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <w4mq5nareqaf3fpwf3hr4oywgxlnjy33va5ftspw5rmdxuflms@x3lw3pj64tig>
Date: Sun, 8 Sep 2024 10:44:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Vasileios Amoiridis <vassilisamir@...il.com>, robh@...nel.org,
saravanak@...gle.com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] of/irq: Use helper to define resources
On Thu, Sep 05, 2024 at 11:34:54AM +0300, Andy Shevchenko wrote:
> On Wed, Sep 04, 2024 at 06:02:38PM +0200, Vasileios Amoiridis wrote:
> > Resources definition can become simpler and more organised by using the
> > dedicated helpers.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> ...
>
> > + *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev))
>
> Just use Elvis to make this shorten.
> Btw, have you ever compiled this?
It wasn't ever built... and if not built, probably not tested, either.
Best regards,
Krzysztof
Powered by blists - more mailing lists